Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename app-scripts to aio-lib-web #286

Merged
merged 3 commits into from
Sep 11, 2020
Merged

rename app-scripts to aio-lib-web #286

merged 3 commits into from
Sep 11, 2020

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 10, 2020 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@purplecabbage purplecabbage mentioned this pull request Sep 10, 2020
Closed
10 tasks
@purplecabbage purplecabbage marked this pull request as ready for review September 11, 2020 02:00
@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #286    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           22        26     +4     
  Lines          792      1235   +443     
  Branches       106       214   +108     
==========================================
+ Hits           792      1235   +443
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/get-url.js 100.00% <100.00%> (ø)
src/commands/app/logs.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)
src/commands/app/undeploy.js 100.00% <100.00%> (ø)
src/lib/app-helper.js 100.00% <100.00%> (ø)
src/lib/config-loader.js 100.00% <100.00%> (ø)
src/lib/owlocal.js 100.00% <100.00%> (ø)
src/lib/poller.js 100.00% <100.00%> (ø)
src/lib/runDev.js 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab5030...bc6a334. Read the comment docs.

@purplecabbage purplecabbage merged commit 7e3183b into adobe:master Sep 11, 2020
@purplecabbage purplecabbage deleted the aio-lib-web branch September 11, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himavanth Himavanth Awaiting requested review from Himavanth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@purplecabbage